Add BLE transfer stall detection to prevent indefinite sync hangs#5
Open
deepseven wants to merge 1 commit intoskorokithakis:masterfrom
Open
Add BLE transfer stall detection to prevent indefinite sync hangs#5deepseven wants to merge 1 commit intoskorokithakis:masterfrom
deepseven wants to merge 1 commit intoskorokithakis:masterfrom
Conversation
Replace the blind transferComplete.await() with a polling-based stall detector that checks buffer growth every 3 seconds. If data stops arriving for 6 consecutive seconds (2 polls), the transfer is considered stalled and automatically retried. This catches a real-world failure mode where the BLE connection stays alive but the firmware stops sending notifications (e.g. Android drops some packets silently). The previous approach would wait the full timeout (45s) before retrying, while this detects the problem in 6 seconds. Also splits the broad catch(Exception) into specific handlers for TimeoutCancellationException, IOException, and CancellationException for clearer error logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the blind transferComplete.await() with a polling-based stall detector that checks buffer growth every 3 seconds. If data stops arriving for 6 consecutive seconds (2 polls), the transfer is considered stalled and automatically retried.
This catches a real-world failure mode where the BLE connection stays alive but the firmware stops sending notifications (e.g. Android drops some packets silently). The previous approach would wait the full timeout (45s) before retrying, while this detects the problem in 6 seconds.
Also splits the broad catch(Exception) into specific handlers for TimeoutCancellationException, IOException, and CancellationException for clearer error logging.